----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/#review276 -----------------------------------------------------------
Ship it! Covers all occurrences of the variant with env, so should be fine. As currently both variants are present, choosing only one of them (no matter which) should not hinder anyone who can already use the scripts today (except if they only used scripts with one of the variants, up to now.) If we later discover that using the other variant would bring any advantage (like, allowing to call the script directly rather than prepending the interpreter command) we can always make that change later. - Boroondas On Jan. 28, 2011, 5:56 p.m., Merov Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/129/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2011, 5:56 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Simple consistency change, using "#!/usr/bin/python" in all python script. > > > This addresses bug STORM-937. > http://jira.secondlife.com/browse/STORM-937 > > > Diffs > ----- > > indra/copy_win_scripts/start-client.py b542f8134a2b > indra/develop.py b542f8134a2b > indra/lib/python/indra/util/simperf_host_xml_parser.py b542f8134a2b > indra/lib/python/indra/util/simperf_oprof_interface.py b542f8134a2b > indra/lib/python/indra/util/test_win32_manifest.py b542f8134a2b > indra/newview/generate_breakpad_symbols.py b542f8134a2b > scripts/build_version.py b542f8134a2b > scripts/install.py b542f8134a2b > > Diff: http://codereview.secondlife.com/r/129/diff > > > Testing > ------- > > Pulled into a test repo and build successfully on all platforms on TC so I > guess no bad surprise here. > > > Thanks, > > Merov > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
