----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/ -----------------------------------------------------------
(Updated Feb. 11, 2011, 6:23 p.m.) Review request for Viewer. Changes ------- The previous change revealed issues on Windows, namely, the use of the commands module on Windows in llversion.py. I changed that to use subprocess instead and cleaned up old svn functions rather than "fixing" them. Summary ------- Simple consistency change, using "#!/usr/bin/python" in all python script. This addresses bug STORM-937. http://jira.secondlife.com/browse/STORM-937 Diffs (updated) ----- indra/cmake/run_build_test.py 92e58e51776a indra/copy_win_scripts/start-client.py 92e58e51776a indra/develop.py 92e58e51776a indra/lib/python/indra/util/llperformance.py 92e58e51776a indra/lib/python/indra/util/llversion.py 92e58e51776a indra/lib/python/indra/util/simperf_proc_interface.py 92e58e51776a indra/lib/python/indra/util/test_win32_manifest.py 92e58e51776a indra/llmessage/tests/test_llsdmessage_peer.py 92e58e51776a indra/llmessage/tests/testrunner.py 92e58e51776a indra/newview/generate_breakpad_symbols.py 92e58e51776a indra/newview/tests/test_llxmlrpc_peer.py 92e58e51776a indra/newview/viewer_manifest.py 92e58e51776a indra/test/test_llmanifest.py 92e58e51776a scripts/build_version.py 92e58e51776a scripts/md5check.py 92e58e51776a scripts/setup-path.py 92e58e51776a scripts/template_verifier.py 92e58e51776a scripts/update_version_files.py 92e58e51776a Diff: http://codereview.secondlife.com/r/129/diff Testing ------- Pulled into a test repo and build successfully on all platforms on TC so I guess no bad surprise here. Thanks, Merov
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges