----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 -----------------------------------------------------------
Ship it! Ah, with that, configuration succeeds and GLH_INCLUDE_DIR gets correctly set to the dir with the symlinks. Could the need for that symlink dir be avoided by having the user directly set the GLH_INCLUDE_DIR CMake variable? indra/cmake/Linking.cmake <http://codereview.secondlife.com/r/167/#comment277> I thought the removal of the NOT STANDALONE condition here would give standalone the same (repository-local) include directories that non-standalone has, so that it'd find autobuild-installed dependencies. But it seems those are just for the library binaries? Or is this just about the creation of those directories, not their addition to the search path? Building still fails for me, with Linking CXX shared library libllcommon.so /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.a when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.a when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lbreakpad_client collect2: ld returned 1 exit status make[2]: *** [llcommon/libllcommon.so] Error 1 make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... and In file included from /usr/include/curl/curl.h:36, from [...]/indra/llmessage/llcurl.h:39, from [...]/indra/llmessage/llurlrequest.h:42, from [...]/indra/llmessage/llhttpclient.h:38, from [...]/indra/llmessage/message.h:53, from [...]/indra/llinventory/llcategory.cpp:30: /usr/include/curl/curlrules.h:144: error: size of array ‘__curl_rule_01__’ is negative /usr/include/curl/curlrules.h:154: error: size of array ‘__curl_rule_02__’ is negative but I guess those are both 32bit/64bit issues and not related to your changes here, so "Ship it!". - Boroondas On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
