> On Feb. 27, 2011, 3:47 a.m., Boroondas Gupte wrote: > > indra/cmake/Linking.cmake, lines 6-20 > > <http://codereview.secondlife.com/r/167/diff/1/?file=998#file998line6> > > > > I thought the removal of the NOT STANDALONE condition here would give > > standalone the same (repository-local) include directories that > > non-standalone has, so that it'd find autobuild-installed dependencies. But > > it seems those are just for the library binaries? Or is this just about the > > creation of those directories, not their addition to the search path?
No, this just sets variables to certain (path) values. No test should ever test if they are set (that would be a wrong design), so they might as well be set. In fact, they ARE being used (at least some of them) on standalone (the staging directories), which is why I removed the if. Also, it's a Good Thing(tm) that the auto-build installed packages (and header files!) are completely invisible on standalone. This should not change. What we need, as I remarked in my other comment, is that we need to create a separate directory where packages can be installed that ARE needed on standalone and then use that, so that we ONLY get packages that we really want/need, and not left-overs from a non-standalone build as well). - Aleric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 ----------------------------------------------------------- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > > > Diffs > ----- > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > ------- > > configures, compiles, runs. > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
