----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review398 -----------------------------------------------------------
indra/llui/lltextbase.cpp <http://codereview.secondlife.com/r/169/#comment282> Only tangent to your code, but is the scoping (the "{" and "}") here doing anything useful? (It causes the "clip" object to be destructed one line earlier, but is that the intention?) Also, it seems the "clip" object is never used. Does it do all its work in its constructor? - Boroondas On March 1, 2011, 1:53 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/169/ > ----------------------------------------------------------- > > (Updated March 1, 2011, 1:53 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed text editor to display the embedded widgets only if they are in the > currently visible area of a text document. > > > This addresses bug STORM-721. > http://jira.secondlife.com/browse/STORM-721 > > > Diffs > ----- > > indra/llui/lltextbase.cpp 767feb16f05f > > Diff: http://codereview.secondlife.com/r/169/diff > > > Testing > ------- > > > Thanks, > > Seth > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
