> On March 1, 2011, 4:01 p.m., Boroondas Gupte wrote: > > indra/llui/lltextbase.cpp, lines 1044-1052 > > <http://codereview.secondlife.com/r/169/diff/1/?file=1014#file1014line1044> > > > > Only tangent to your code, but is the scoping (the "{" and "}") here > > doing anything useful? (It causes the "clip" object to be destructed one > > line earlier, but is that the intention?) > > > > Also, it seems the "clip" object is never used. Does it do all its work > > in its constructor?
The clip object here does all its work in the constructor (see usage example in lllocalcliprect.h) - it clips the area inside which GL objects are rendered. I tried to change the logic as little as possible so I moved the call to LLUICtrl::draw() to render the document view after drawText() is called to avoid possible blinking caused by hiding some of the embedded widgets. In case when LLUICtrl::draw() is called prior to drawText() some embedded widgets located outside visible document area will appear for a single frame before they are hidden in drawText(). - Seth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review398 ----------------------------------------------------------- On March 1, 2011, 1:53 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/169/ > ----------------------------------------------------------- > > (Updated March 1, 2011, 1:53 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed text editor to display the embedded widgets only if they are in the > currently visible area of a text document. > > > This addresses bug STORM-721. > http://jira.secondlife.com/browse/STORM-721 > > > Diffs > ----- > > indra/llui/lltextbase.cpp 767feb16f05f > > Diff: http://codereview.secondlife.com/r/169/diff > > > Testing > ------- > > > Thanks, > > Seth > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
