----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/170/ -----------------------------------------------------------
Review request for Viewer. Summary ------- Cumulative diff of changes made by Wolfpup, Richard and me. Description: * Ability to hide the Speak button with the bottom tray context menu. * Made the chat input resize handle visible, so that the feature is easily discoverable. * Applied Richard's fix to layout panel resizing logic. My changes: * Made the Speak button inhibit auto-hiding (that is its original behavior). This also fixes numerous glitches with buttons resizing/positioning. * Fixed resize cursor drawn on a non-Speak button to the right of the chat input. * Reverted wrong changes to LLSpeakButton class: - The correct way to hide a button is either removing it from the parent's child list or calling button->setVisible(FALSE). - There was no need to narrow the speaking indicator. * Moved the drag handle icon file to icons/bottomtray/ folder. * Cleanups. This addresses bug STORM-236. http://jira.secondlife.com/browse/STORM-236 Diffs ----- doc/contributions.txt 767feb16f05f indra/llui/lllayoutstack.cpp 767feb16f05f indra/newview/llbottomtray.h 767feb16f05f indra/newview/llbottomtray.cpp 767feb16f05f indra/newview/skins/default/textures/bottomtray/ChatBarHandle.png 767feb16f05f indra/newview/skins/default/textures/textures.xml 767feb16f05f indra/newview/skins/default/xui/en/menu_bottomtray.xml 767feb16f05f indra/newview/skins/default/xui/en/panel_bottomtray.xml 767feb16f05f Diff: http://codereview.secondlife.com/r/170/diff Testing ------- Thanks, Vadim
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges