-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/170/
-----------------------------------------------------------
(Updated March 4, 2011, 3:45 a.m.)
Review request for Viewer.
Changes
-------
Changes:
- Added comments requested by Wolfpup.
- To decrease code duplication:
* Added RS_BUTTON_SPEAK to the button->panel mapping
(mStateProcessedObjectMap).
* Replaced all lookups in mStateProcessedObjectMap with calls to
getButtonPanel().
Summary
-------
Cumulative diff of changes made by Wolfpup, Richard and me.
Description:
* Ability to hide the Speak button with the bottom tray context menu.
* Made the chat input resize handle visible, so that the feature is easily
discoverable.
* Applied Richard's fix to layout panel resizing logic.
My changes:
* Made the Speak button inhibit auto-hiding (that is its original behavior).
This also fixes numerous glitches with buttons resizing/positioning.
* Fixed resize cursor drawn on a non-Speak button to the right of the chat
input.
* Reverted wrong changes to LLSpeakButton class:
- The correct way to hide a button is either removing it from the parent's
child list
or calling button->setVisible(FALSE).
- There was no need to narrow the speaking indicator.
* Moved the drag handle icon file to icons/bottomtray/ folder.
* Cleanups.
This addresses bug STORM-236.
http://jira.secondlife.com/browse/STORM-236
Diffs (updated)
-----
doc/contributions.txt 8596ccc522d9
indra/llui/lllayoutstack.cpp 8596ccc522d9
indra/newview/llbottomtray.h 8596ccc522d9
indra/newview/llbottomtray.cpp 8596ccc522d9
indra/newview/skins/default/textures/bottomtray/ChatBarHandle.png
8596ccc522d9
indra/newview/skins/default/textures/textures.xml 8596ccc522d9
indra/newview/skins/default/xui/en/menu_bottomtray.xml 8596ccc522d9
indra/newview/skins/default/xui/en/panel_bottomtray.xml 8596ccc522d9
Diff: http://codereview.secondlife.com/r/170/diff
Testing
-------
Thanks,
Vadim
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
