----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review496 -----------------------------------------------------------
I think that pressing the Speak button or the fly-out button should hide the hint: this is the way how e.g. the Move button hint works. Otherwise the hint obscures the NEARBY VOICE panel which looks pretty weird. indra/newview/skins/default/xui/en/notifications.xml <http://codereview.secondlife.com/r/229/#comment364> I guess you meant that *voice* is enabled by default, not microphone. Mic only gets enabled explicitly by pressing the Speak button or middle mouse button. - Vadim On March 23, 2011, 6:06 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/229/ > ----------------------------------------------------------- > > (Updated March 23, 2011, 6:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > 1) Change Voice Enabled to Speak Button when you right click on the bottom > bar and get a menu. > > 2) Eliminate the separator bar in this menu. > > 3) Have a hint appear for the Speak button (see image in jira) the first time > you use the viewer, have voice on (the default), and successfully connect to > a voice server. > > > This addresses bug STORM-1077. > http://jira.secondlife.com/browse/STORM-1077 > > > Diffs > ----- > > doc/contributions.txt b761ed94eb26 > indra/newview/app_settings/ignorable_dialogs.xml b761ed94eb26 > indra/newview/llbottomtray.cpp b761ed94eb26 > indra/newview/llfirstuse.h b761ed94eb26 > indra/newview/llfirstuse.cpp b761ed94eb26 > indra/newview/skins/default/xui/en/menu_bottomtray.xml b761ed94eb26 > indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 > > Diff: http://codereview.secondlife.com/r/229/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
