----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review502 -----------------------------------------------------------
Ship it! No more objections. Thanks, Jonathan! To avoid problems with uploading modified diffs, try using cumulative diffs, i.e. each uploaded diff includes all changes from the previous one. Thus you can use Review Board to see differences between the diffs, and each diff is perfectly useful and self-contained. - Vadim On March 24, 2011, 9:10 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/229/ > ----------------------------------------------------------- > > (Updated March 24, 2011, 9:10 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > 1) Change Voice Enabled to Speak Button when you right click on the bottom > bar and get a menu. > > 2) Eliminate the separator bar in this menu. > > 3) Have a hint appear for the Speak button (see image in jira) the first time > you use the viewer, have voice on (the default), and successfully connect to > a voice server. > > > This addresses bug STORM-1077. > http://jira.secondlife.com/browse/STORM-1077 > > > Diffs > ----- > > indra/newview/llcallfloater.cpp b761ed94eb26 > indra/newview/llspeakbutton.cpp b761ed94eb26 > indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 > > Diff: http://codereview.secondlife.com/r/229/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
