----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/#review549 -----------------------------------------------------------
Looks fine, except for two issues. indra/llui/llurlaction.h <http://codereview.secondlife.com/r/249/#comment482> I don't agree that LLURLAction as an appropriate place for this method: the method does no user-visible action ant thus should be moved to an auxiliary class (not sure which one, needs investigation). indra/newview/llimview.cpp <http://codereview.secondlife.com/r/249/#comment483> What happens to messages logged in between the call to buildUserName() and the moment when the name gets asynchronously refreshed by onAvatarNameCache()? It looks like the messages may be logged to a different file than subsequent ones. If that's the case, maybe the old file should be renamed once you've got the updated name? - Vadim On April 4, 2011, 4:30 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/249/ > ----------------------------------------------------------- > > (Updated April 4, 2011, 4:30 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed IM history to use the resident's user name for the log file name. > Added conversions from legacy names or SLURLs with avatar id to the user > names in cases of logging P2P sessions and inventory offers. > > > This addresses bug STORM-941. > http://jira.secondlife.com/browse/STORM-941 > > > Diffs > ----- > > indra/llui/llurlaction.h d30636c2a83a > indra/llui/llurlaction.cpp d30636c2a83a > indra/newview/llgiveinventory.cpp d30636c2a83a > indra/newview/llimview.cpp d30636c2a83a > indra/newview/llnotificationhandler.h d30636c2a83a > indra/newview/llnotificationhandlerutil.cpp d30636c2a83a > > Diff: http://codereview.secondlife.com/r/249/diff > > > Testing > ------- > > > Thanks, > > Seth > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
