> On April 5, 2011, 9:02 a.m., Wolfpup Lowenhar wrote: > > indra/llui/llurlaction.h, line 81 > > <http://codereview.secondlife.com/r/249/diff/1/?file=1396#file1396line81> > > > > Having this here looks to be the best way to prevent generating a > > Legacy named P2P system message during said conversation that has been > > started by a person that DOSE NOT have Display Names turned on as there is > > one SYSTEM message that would seem to be coming from no where and this > > looks like it is its source.
I guess Vadim is right about moving the method. Seems that just stripping a UUID part of a given SLURL doesn't really belong here, but moving it won't affect the patch functionality. Wolfpup, do you have some objections against moving the method or some suggestions about the functionality changes? - Seth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/#review550 ----------------------------------------------------------- On April 4, 2011, 4:30 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/249/ > ----------------------------------------------------------- > > (Updated April 4, 2011, 4:30 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed IM history to use the resident's user name for the log file name. > Added conversions from legacy names or SLURLs with avatar id to the user > names in cases of logging P2P sessions and inventory offers. > > > This addresses bug STORM-941. > http://jira.secondlife.com/browse/STORM-941 > > > Diffs > ----- > > indra/llui/llurlaction.h d30636c2a83a > indra/llui/llurlaction.cpp d30636c2a83a > indra/newview/llgiveinventory.cpp d30636c2a83a > indra/newview/llimview.cpp d30636c2a83a > indra/newview/llnotificationhandler.h d30636c2a83a > indra/newview/llnotificationhandlerutil.cpp d30636c2a83a > > Diff: http://codereview.secondlife.com/r/249/diff > > > Testing > ------- > > > Thanks, > > Seth > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
