----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review591 -----------------------------------------------------------
Thanks, Jonathan. No major issues this time. I've got a few comments though, in addition to what Boroondas said: indra/newview/llbottomtray.cpp <http://codereview.secondlife.com/r/244/#comment538> Any reason not to move this to LLNearbyChatBar::postBuild() ? indra/newview/llnearbychatbar.h <http://codereview.secondlife.com/r/244/#comment533> again the redundant change indra/newview/llnearbychatbar.cpp <http://codereview.secondlife.com/r/244/#comment534> RB seems to be set up to ignore whitespace changes and thus doesn't show this... but you've removed the leading tab here. Please avoid irrelevant changes. indra/newview/llviewerchat.h <http://codereview.secondlife.com/r/244/#comment535> Replace the redundant "public:" marker with an empty line. indra/newview/llviewerchat.h <http://codereview.secondlife.com/r/244/#comment536> CS: remove spaces near parenthesis. indra/newview/llviewerchat.cpp <http://codereview.secondlife.com/r/244/#comment537> CS: extra spaces near parenthesis - Vadim On April 13, 2011, 6:40 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/244/ > ----------------------------------------------------------- > > (Updated April 13, 2011, 6:40 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Chat preferences > font size should increase size of input text in the chat > box > > > This addresses bug STORM-1095. > http://jira.secondlife.com/browse/STORM-1095 > > > Diffs > ----- > > doc/contributions.txt a8f868007986 > indra/llui/lllineeditor.h a8f868007986 > indra/llui/lllineeditor.cpp a8f868007986 > indra/newview/llbottomtray.cpp a8f868007986 > indra/newview/llfloaterpreference.cpp a8f868007986 > indra/newview/llnearbychatbar.h a8f868007986 > indra/newview/llnearbychatbar.cpp a8f868007986 > indra/newview/llviewerchat.h a8f868007986 > indra/newview/llviewerchat.cpp a8f868007986 > > Diff: http://codereview.secondlife.com/r/244/diff > > > Testing > ------- > > Change font size in preferences and see > 1) Font size in chat input box changes to new size immediately > 2) Font size is set to selected size when viewer is restarted > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
