> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1450#file1450line560> > > > > Any reason not to move this to LLNearbyChatBar::postBuild() ?
Yes, there is a reason, though not necessarily a good one -- the same change was made for Storm-1094 which would probably have the merge monkey send it back for me to re-merge. Since I cannot compile with autobuild I would not be able to test this change and thus it would languish for a month+ until I have time to work on getting my autobuild issue resolved. > On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llnearbychatbar.h, line 39 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1452#file1452line39> > > > > again the redundant change I don't know why hg diff is picking up this blank line. > On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llnearbychatbar.cpp, line 444 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1453#file1453line444> > > > > RB seems to be set up to ignore whitespace changes and thus doesn't > > show this... but you've removed the leading tab here. > > > > Please avoid irrelevant changes. Fixed. Thanks for catching this. > On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llviewerchat.h, line 39 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1454#file1454line39> > > > > Replace the redundant "public:" marker with an empty line. Also fixed, though in other LL code, where there are larger blocks to organize, multiple public: lines are found. > On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llviewerchat.h, line 47 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1454#file1454line47> > > > > CS: remove spaces near parenthesis. Done. > On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llviewerchat.cpp, line 261 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1455#file1455line261> > > > > CS: extra spaces near parenthesis Done. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review591 ----------------------------------------------------------- On April 13, 2011, 12:32 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/244/ > ----------------------------------------------------------- > > (Updated April 13, 2011, 12:32 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Chat preferences > font size should increase size of input text in the chat > box > > > This addresses bug STORM-1095. > http://jira.secondlife.com/browse/STORM-1095 > > > Diffs > ----- > > doc/contributions.txt a8f868007986 > indra/llui/lllineeditor.h a8f868007986 > indra/llui/lllineeditor.cpp a8f868007986 > indra/newview/llbottomtray.cpp a8f868007986 > indra/newview/llfloaterpreference.cpp a8f868007986 > indra/newview/llnearbychatbar.h a8f868007986 > indra/newview/llnearbychatbar.cpp a8f868007986 > indra/newview/llviewerchat.h a8f868007986 > indra/newview/llviewerchat.cpp a8f868007986 > > Diff: http://codereview.secondlife.com/r/244/diff > > > Testing > ------- > > Change font size in preferences and see > 1) Font size in chat input box changes to new size immediately > 2) Font size is set to selected size when viewer is restarted > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
