----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review603 -----------------------------------------------------------
Ship it! Looks fine and works well for me, however I don't quite understand why to limit your changes with XML files. Resizing the mini-map might improve usability. indra/newview/app_settings/settings.xml <http://codereview.secondlife.com/r/265/#comment565> I'd say "nearby people list", not "nearby list". indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml <http://codereview.secondlife.com/r/265/#comment568> I'd say "View Mini-Map": by "Map" we usually mean the world map, which is obviously a different thing. indra/newview/skins/default/xui/en/panel_people.xml <http://codereview.secondlife.com/r/265/#comment566> Reformat with alphabetic parameter order and place one parameter per line. That's more diff-friendly and also improves compatibility with the XUI preview tool. indra/newview/skins/default/xui/en/panel_people.xml <http://codereview.secondlife.com/r/265/#comment569> This looks like irrelevant change. - Vadim On April 14, 2011, 5:29 a.m., Twisted Laws wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/265/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 5:29 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Patch makes the map in the Nearby people tab optional with a menu option in > the gear > menu. Patch is XML only and resizing of the map is disabled > (user_resize="false" in > the layout_panels) as I could not find a way to easily save window sizes > purely in XML. > Patch is in the repository of > https://Twisted_Laws/viewer-development-storm-1103 as > https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af > > > This addresses bug STORM-1103. > http://jira.secondlife.com/browse/STORM-1103 > > > Diffs > ----- > > doc/contributions.txt ee4d271eef9b > indra/newview/app_settings/settings.xml ee4d271eef9b > indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml > ee4d271eef9b > indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b > > Diff: http://codereview.secondlife.com/r/265/diff > > > Testing > ------- > > Tested by exercising the gear menu option of "View Map" with the People tab > attached > and detached insuring the map appears and disappears properly. > > > Thanks, > > Twisted > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
