> On April 14, 2011, 12:37 p.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/panel_people.xml, lines 117-127 > > <http://codereview.secondlife.com/r/265/diff/1/?file=1475#file1475line117> > > > > I'd prefer to have the attributes ordered semantically (i.e. 'name' > > first, 'top' and 'left' right after each other, 'height' and 'width' right > > after each other etc.) rather than alphabetically. But as the surrounding > > code also seems to have its attributes ordered alphabetically, we might as > > well stick to that. Though, then, keep_one_selected should be moved up. > > Twisted Laws wrote: > I always wondered about the sequencing of these, but I figured that it > was some application that > made it easier to work on these did that ordering. The code that reads > it doesn't care about ordering. > As far as if fields are required or not, I've no idea as I don't believe > I have any access to any > documentation. Me working on XML files is try it, change it, try it, > etc... > > I'll leave it sit a little while for any other comments, and then I'll > change it as you suggest.
The application is the XUI preview tool (Ctrl+T in the login screen). It dumps XMLs with attributes sorted by name. Please do so as well. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review602 ----------------------------------------------------------- On April 14, 2011, 5:29 a.m., Twisted Laws wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/265/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 5:29 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Patch makes the map in the Nearby people tab optional with a menu option in > the gear > menu. Patch is XML only and resizing of the map is disabled > (user_resize="false" in > the layout_panels) as I could not find a way to easily save window sizes > purely in XML. > Patch is in the repository of > https://Twisted_Laws/viewer-development-storm-1103 as > https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af > > > This addresses bug STORM-1103. > http://jira.secondlife.com/browse/STORM-1103 > > > Diffs > ----- > > doc/contributions.txt ee4d271eef9b > indra/newview/app_settings/settings.xml ee4d271eef9b > indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml > ee4d271eef9b > indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b > > Diff: http://codereview.secondlife.com/r/265/diff > > > Testing > ------- > > Tested by exercising the gear menu option of "View Map" with the People tab > attached > and detached insuring the map appears and disappears properly. > > > Thanks, > > Twisted > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
