> On April 1, 2011, 4:22 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.h, lines 168-170 > > <http://codereview.secondlife.com/r/231/diff/3/?file=1373#file1373line168> > > > > Shouldn't this be a (non-static) method of LLMulitGesture taking no > > argument, rather than a static member of LLGestureMgr taking a pointer to a > > gesture? > > > > Also, the gesture should not be changed by that, should it? If > > possible, make the argument type pointer-to-const (or, if you make it a > > method of LLMultiGesture as suggested, make it a const method). > > Seth ProductEngine wrote: > It could be a non-static method of LLMulitGesture if a gesture would be > an observer of its own pending assets, or if a gesture would check pending > assets from the list stored at LLGestureMgr. In this case the LLMulitGesture > class becomes more complicated without any gain in performance because this > is the same check that LLGestureMgr::hasLoadingAssets() does.
OK. Could you still consider to pass a pointer-to-const? - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review531 ----------------------------------------------------------- On March 31, 2011, 10:18 a.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/231/ > ----------------------------------------------------------- > > (Updated March 31, 2011, 10:18 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Added syncing animations and sounds before the gesture starts playing. > The actual playing of animations and sounds of a gesture starts only when all > needed animations and sound files are loaded into viewer cache. This reduces > the delay between animations and sounds meant to be played simultaneously but > may increase the delay between the moment a gesture is triggered and the > moment it starts playing. > > Fixed calling assets callback to clean up the void pointer in getAssetData() > and avoid potential memory leaks. > > > This addresses bug STORM-380. > http://jira.secondlife.com/browse/STORM-380 > > > Diffs > ----- > > indra/llmessage/llassetstorage.cpp d30636c2a83a > indra/newview/llgesturemgr.h d30636c2a83a > indra/newview/llgesturemgr.cpp d30636c2a83a > > Diff: http://codereview.secondlife.com/r/231/diff > > > Testing > ------- > > > Thanks, > > Seth > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
