> On April 25, 2011, 10:27 a.m., Vadim ProductEngine wrote: > > Looks good, thanks. > > > > One note that applies to my patch as well: rfind() seems to fit better than > > find() in this case. > > Boroondas Gupte wrote: > Using string::rfind instead of string::find would avoid problems if > someone checks out the source to a path already containing "/build-darwin-" > or "/build-linux-", I guess?
Yep, that's what I meant. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/#review647 ----------------------------------------------------------- On April 25, 2011, 5:09 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/277/ > ----------------------------------------------------------- > > (Updated April 25, 2011, 5:09 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review > request's diff) and applied analogous changes to lldir_mac.cpp, in hope that > this would fix the same issue on Mac, too: > * renamed indra_pos to build_dir_pose (just for consistency. This should not > have any effect.) > * search for "/build-darwin-" rather than "/indra" within mExecutableDir (The > new build dir prefix is taken from .hgignore, in the hope that is up to date.) > > > This addresses bug STORM-1182. > http://jira.secondlife.com/browse/STORM-1182 > > > Diffs > ----- > > doc/contributions.txt 9c0506d10226 > indra/llvfs/lldir_linux.cpp 9c0506d10226 > indra/llvfs/lldir_mac.cpp 9c0506d10226 > > Diff: http://codereview.secondlife.com/r/277/diff > > > Testing > ------- > > None, as I don't have a mac. > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
