-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/277/
-----------------------------------------------------------
(Updated April 25, 2011, 4:40 p.m.)
Review request for Viewer.
Changes
-------
Use string::rfind instead of string::find, so last occurrence of build dir
prefix will be matched.
Summary
-------
Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review
request's diff) and applied analogous changes to lldir_mac.cpp, in hope that
this would fix the same issue on Mac, too:
* renamed indra_pos to build_dir_pose (just for consistency. This should not
have any effect.)
* search for "/build-darwin-" rather than "/indra" within mExecutableDir (The
new build dir prefix is taken from .hgignore, in the hope that is up to date.)
This addresses bug STORM-1182.
http://jira.secondlife.com/browse/STORM-1182
Diffs (updated)
-----
doc/contributions.txt 9c0506d10226
indra/llvfs/lldir_linux.cpp 9c0506d10226
indra/llvfs/lldir_mac.cpp 9c0506d10226
Diff: http://codereview.secondlife.com/r/277/diff
Testing
-------
None, as I don't have a mac.
Thanks,
Boroondas
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
