----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/312/#review705 -----------------------------------------------------------
autobuild/autobuild_tool_source_environment.py <http://codereview.secondlife.com/r/312/#comment676> Add a space between 'solution' and the opening brace, too. autobuild/autobuild_tool_source_environment.py <http://codereview.secondlife.com/r/312/#comment680> Remove trailing whitespace, please. autobuild/autobuild_tool_source_environment.py <http://codereview.secondlife.com/r/312/#comment677> Wait, wait, wait ... I didn't notice this before, but ... autobuild/autobuild_tool_source_environment.py <http://codereview.secondlife.com/r/312/#comment678> ... are you really doing the exact same in both, the if and the else case? What testing is then needed to eliminate the conditioning? (Note that [ -z ... ] only tests whether the string is empty, and doesn't modify anything.) - Boroondas On May 17, 2011, 3:42 p.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/312/ > ----------------------------------------------------------- > > (Updated May 17, 2011, 3:42 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Convert autobuild library builds to use msbuild.exe instead of devenv.com. > Includes Ima Mechanique change from http://codereview.secondlife.com/r/305/ > > > This addresses bug OPEN-69. > http://jira.secondlife.com/browse/OPEN-69 > > > Diffs > ----- > > autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 > > Diff: http://codereview.secondlife.com/r/312/diff > > > Testing > ------- > > Made calling script 3p-ogvoribs/build-cmd.sh changes, which will be published > later, to use msbuild parameters and successfully built and packaged library. > Compared files in the package to those from LL prebuilt download and they > match by name and size. > TODO: Build the viewer with the local package. > > Built and packaged 3p-ogvorbis with added parameters. > > > Thanks, > > Nicky > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
