----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/312/ -----------------------------------------------------------
(Updated May 18, 2011, 4:01 a.m.) Review request for Viewer. Changes ------- Added a space and removed trailing white space. ... are you really doing the exact same in both, the if and the else case? What testing is then needed to eliminate the conditioning? I couldn't get into the head of the original writer of the code. So, as a precaution kept logic in place. I am waiting for LL to run this and say no problems encountered. Or, another windows developer to pipe in and say this s how solutions and projects are called together when using msbuild.exe. That would allow the calling build-cmd.sh to keep the same calling logic Namely, this run is a solution without a project or this run is a project within a solution. Please look at OPEN-70 to see changes to a calling build-cmd.sh. Summary ------- Convert autobuild library builds to use msbuild.exe instead of devenv.com. Includes Ima Mechanique change from http://codereview.secondlife.com/r/305/ This addresses bug OPEN-69. http://jira.secondlife.com/browse/OPEN-69 Diffs (updated) ----- autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 Diff: http://codereview.secondlife.com/r/312/diff Testing (updated) ------- Made calling script 3p-ogvoribs/build-cmd.sh changes, which will be published later, to use msbuild parameters and successfully built and packaged library. Compared files in the package to those from LL prebuilt download and they match by name and size. TODO: Build the viewer with the local package. DONE: Built viewer (16169) prior to mesh and logged to agni and played audio streams with no problems. Built and packaged 3p-ogvorbis with added parameters. Thanks, Nicky
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
