----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/307/#review712 -----------------------------------------------------------
indra/llvfs/lldiriterator.cpp <http://codereview.secondlife.com/r/307/#comment681> Meh, my backwards-compatibility approach does not work: The existance of fs::path::native() will be checked by the compiler, even when this method is never called and thus (as it's inlined) would never even show up in the binary. - Boroondas On May 18, 2011, 1:13 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/307/ > ----------------------------------------------------------- > > (Updated May 18, 2011, 1:13 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Some trickery needed to make this forward compatible to newer Boost versions > while keeping compatibility to the currently used Boost version. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > ----- > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/307/diff > > > Testing > ------- > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > Not tested: > * non-standalone > * other boost versions (At least one version <= 1.43 should be tested! > Preferably the one LL currently uses.) > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
