> On May 24, 2011, 3:32 p.m., Boroondas Gupte wrote: > > indra/llvfs/lldiriterator.cpp, lines 140-144 > > <http://codereview.secondlife.com/r/307/diff/2/?file=2546#file2546line140> > > > > Meh, my backwards-compatibility approach does not work: The existance > > of fs::path::native() will be checked by the compiler, even when this > > method is never called and thus (as it's inlined) would never even show up > > in the binary.
A hopefully better fix is under review at https://codereview.secondlife.com/r/313/ - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/307/#review712 ----------------------------------------------------------- On May 24, 2011, 3:41 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/307/ > ----------------------------------------------------------- > > (Updated May 24, 2011, 3:41 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Some trickery needed to make this forward compatible to newer Boost versions > while keeping compatibility to the currently used Boost version. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > ----- > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/307/diff > > > Testing > ------- > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > * Tried to compile Viewer (standalone) with Boost 1.45 (which has the new > API, but apparently defaults to the old one) > ** this fails with > indra/llvfs/lldiriterator.cpp:143: error: ‘const struct > boost::filesystem2::path’ has no member named ‘native’ > > Not tested: > * non-standalone > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
