----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/315/#review716 -----------------------------------------------------------
Ship it! looks good to me. - Richard On May 27, 2011, 1:04 p.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/315/ > ----------------------------------------------------------- > > (Updated May 27, 2011, 1:04 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a patch to fix the issues with clearing viewer caches documented in > VWR-25862. I removed the leading delimiter in the place where each of the > three caches are cleared. I also removed the mac specific deleteFilesInDir() > method, which should have been removed for STORM-477. I removed unneeded > calls to getDirDelimiter() in llvocache.cpp. > > > This addresses bugs vwr-25681 and vwr-25862. > http://jira.secondlife.com/browse/vwr-25681 > http://jira.secondlife.com/browse/vwr-25862 > > > Diffs > ----- > > indra/llvfs/lldir_mac.h UNKNOWN > indra/llvfs/lldir_mac.cpp UNKNOWN > indra/newview/llappviewer.cpp UNKNOWN > indra/newview/lltexturecache.cpp UNKNOWN > indra/newview/llvocache.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/315/diff > > > Testing > ------- > > Test plan: https://jira.secondlife.com/browse/VWR-25862?#comment-262800 > > I built and tested on Mac, Windows and Linux and saw the correct behavior > when clicking the clear history button and the move cache button. > > > Thanks, > > Log > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
