> On June 6, 2011, 8:37 a.m., Aleric Inglewood wrote: > > indra/newview/llvocache.cpp, lines 366-369 > > <http://codereview.secondlife.com/r/315/diff/2/?file=2843#file2843line366> > > > > This patch removes (everywhere, not just here) the delimiter in front > > of 'mask' passed to deleteFilesInDir. > > > > deleteFilesInDir does nothing with mask but pass it to LLDirIterator. > > Apparently, the introduction of LLDirIterator (new in Viewer 2) requires > > mask to NOT start with a delimiter. > > > > However, you fail to correct this consistently; for example, in > > LLAppViewer::migrateCacheDirectory we have the following code: > > > > std::string mask = delimiter + "*.*"; > > > > LLDirIterator iter(old_cache_dir, mask); > > > > Can you explain that works (does it?) and the code that you changed > > didn't work? > >
You're right, I checked the calls to deleteFilesInDir and fixed the ones that I felt able to reproduce and show that they were fixed. I reported the other calls to deleteFilesInDir that need to be fixed as subtasks of VWR-25861. I didn't check the other uses of LLDirIterator because I thought they would have been fixed when STORM-477 was merged. I'll fix what I can and report the others. Thanks - Log ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/315/#review724 ----------------------------------------------------------- On May 27, 2011, 1:04 p.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/315/ > ----------------------------------------------------------- > > (Updated May 27, 2011, 1:04 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a patch to fix the issues with clearing viewer caches documented in > VWR-25862. I removed the leading delimiter in the place where each of the > three caches are cleared. I also removed the mac specific deleteFilesInDir() > method, which should have been removed for STORM-477. I removed unneeded > calls to getDirDelimiter() in llvocache.cpp. > > > This addresses bugs vwr-25681 and vwr-25862. > http://jira.secondlife.com/browse/vwr-25681 > http://jira.secondlife.com/browse/vwr-25862 > > > Diffs > ----- > > indra/llvfs/lldir_mac.h UNKNOWN > indra/llvfs/lldir_mac.cpp UNKNOWN > indra/newview/llappviewer.cpp UNKNOWN > indra/newview/lltexturecache.cpp UNKNOWN > indra/newview/llvocache.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/315/diff > > > Testing > ------- > > Test plan: https://jira.secondlife.com/browse/VWR-25862?#comment-262800 > > I built and tested on Mac, Windows and Linux and saw the correct behavior > when clicking the clear history button and the move cache button. > > > Thanks, > > Log > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
