----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/#review759 -----------------------------------------------------------
indra/newview/llnearbychathandler.cpp <http://codereview.secondlife.com/r/341/#comment716> This function's return type should be changed to bool, if it's intended for use with std::sort. (And that's how it's being used currently.) - Boroondas On June 16, 2011, 1:52 p.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/341/ > ----------------------------------------------------------- > > (Updated June 16, 2011, 1:52 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Apparently, a nearby chat toast got somehow destroyed while still remaining > in the list of active toasts. > Attempt to sort active toasts in showToastsBottom() then triggered the crash. > > I don't know how to reproduce the crash, i.e. force destroying a toast in a > way that its onClose() method (which would remove references to the toast) > isn't called. > So we'll just remove references to the toast whenever it's destroyed. > > > This addresses bug STORM-1352. > http://jira.secondlife.com/browse/STORM-1352 > > > Diffs > ----- > > indra/newview/llnearbychathandler.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/341/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
