> On June 20, 2011, 10:01 a.m., Boroondas Gupte wrote: > > You third diff file (STORM-1352_2.diff) seems to be incremental instead of > > total. Please always use total diffs on RB, so that the full change can be > > seen and differences between versions of the change can be viewed to > > compare.
Ok. > On June 20, 2011, 10:01 a.m., Boroondas Gupte wrote: > > indra/newview/llnearbychathandler.cpp, lines 375-382 > > <http://codereview.secondlife.com/r/341/diff/3/?file=3017#file3017line375> > > > > On second thought, wouldn't it be good to at least issue a warning here > > if one of the get()s returns NULL? We might be sorting stuff that isn't > > there, which is clearly a sign that something's fishy. Right, I'll add a warning. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/#review779 ----------------------------------------------------------- On June 20, 2011, 6:55 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/341/ > ----------------------------------------------------------- > > (Updated June 20, 2011, 6:55 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Apparently, a nearby chat toast got somehow destroyed while still remaining > in the list of active toasts. > Attempt to sort active toasts in showToastsBottom() then triggered the crash. > > I don't know how to reproduce the crash, i.e. force destroying a toast in a > way that its onClose() method (which would remove references to the toast) > isn't called. > So we'll just remove references to the toast whenever it's destroyed. > > > This addresses bug STORM-1352. > http://jira.secondlife.com/browse/STORM-1352 > > > Diffs > ----- > > indra/newview/llnearbychathandler.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/341/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
