-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/
-----------------------------------------------------------
(Updated June 24, 2011, 4:45 a.m.)
Review request for Viewer.
Summary
-------
This is a patch by ArminWeatherHax. I am creating the request to help speed
this fix along in the system.
----
Ways to reproduce: log into a simulator.
Reproduces: always
Affects: any version supported, probably all 3rd party viewers but Kokua (and
Imprudence, soon).
What happens:
In each idle cycle the voice client requests the "ParcelVoiceInfoRequest"
capability, thats each time a HTTP GET.
See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel
boundary crossing
Expected:
On parcel/region change request the capability once. It's not the region that
rezzes in, but the avatar, so do the request for the capability not earlier
than the agents region signals capabilitiesReceived() true. After that you are
sure if the region returns an empty url you can give up for that region.
Not sure about the impact on lag - requesting and returning an url is not much
data transmitted, though its a pretty big number of people doing it over and
over per second (no matter if they have voice on or off).
----
going once again through llviewerregion I see its fortunately not each time a
HTTP GET, just once when the agent connects to the region. Though the patch
still saves all the lookup if the cap is there while it can't be possibly.
This addresses bug VWR-25923.
http://jira.secondlife.com/browse/VWR-25923
Diffs (updated)
-----
doc/contributions.txt 04e2a3ddca51
indra/newview/llviewerregion.h 04e2a3ddca51
indra/newview/llviewerregion.cpp 04e2a3ddca51
indra/newview/llvoicevivox.h 04e2a3ddca51
indra/newview/llvoicevivox.cpp 04e2a3ddca51
Diff: http://codereview.secondlife.com/r/333/diff
Testing
-------
Thanks,
Jonathan
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
