> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote:
> > When I applied this latest patch to firestorm, which is based off of LL 
> > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of 
> > 256 to other regions.  I tried multiple times TPing from the area around 
> > help island public to magnum sandbox 4 or to help people island.  In every 
> > case I timed and was logged off after the TP was completed, as the viewer 
> > was cleaning up and closing connections to the old regions.  I don't have 
> > this problem with the first iteration of this patch.  I feel this scenario 
> > needs to be tested with this latest patch on v-dev tip to make sure this 
> > doesn't happen there as well.
> > 
> > The account I used only has 4 friends, and around 24 items in the inventory 
> > in addition to the library.  It also only has 2 attachments (a hud and the 
> > firestorm bridge) and is one of the noob outfits.  I also am running on an 
> > i7 2600k, 16GB ram, ATI 6970, and 20/5mbit FIOS connection.
> 
> Vadim ProductEngine wrote:
>     Could you please provide exact steps to reproduce the issue?
>     Have you tried reverting the patch and repeating the teleport attempt?
> 
> Tankmaster Finesmith wrote:
>     I TPed to Help Island Public, which is on maind land, while running from 
> Visual Studio.  Draw distance set to 256.  Flew over orentation island and 
> proceeded onto another neighboring sim.  My viewer is now connected to 
> several different regions do to normal viewer behavior.  I then TP to magnum 
> sandbox 4 by tyeping that into the nav bar up top and pressing enter.  
>     
>     First tried with the first patch, which we have had for several weeks now 
> in our repository:
>     -TP was successful, then the viewer became rather unresponsive and the 
> logs say things related to "(ip address) time out exceeded, disconnecting" 
> but eventually recovers
>     -repeated 3 times, last time I TPed to Help People Island instead and all 
> times got the same result
>     
>     Second I tried with the updated patch:
>     -TP was successful, then the viewer was completely unresponsive, and I 
> eventually got the ding from getting logged off and in the loges I see a mass 
> of "invalid packet from (IP address)"
>     -repeated 3 times like and to the same regions (twice to magnum, once to 
> HPI) every time I got logged off
>     
>     Third I reverted back to the first patch:
>     Same experience as the first:
>     -TP was successful, then the viewer became rather unresponsive and the 
> logs say things related to "(ip address) time out exceeded, disconnecting" 
> but eventually recovers
>     -repeated 3 times, last time I TPed to HPI as I have in the other tests, 
> and all times got the same result 
>     
>     
>     In talking with armin, he got similer results but thinks its the magnum 
> sandbox region that may be having problems.  I am not as sure on that as I 
> get it when TPing to HPI as well which is release server channle and not a RC 
> channle.

Thanks, Tankmaster. I tend to think that these errors are not related to the 
patch.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review819
-----------------------------------------------------------


On June 24, 2011, 4:45 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> -----------------------------------------------------------
> 
> (Updated June 24, 2011, 4:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> ----
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> ----
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the region. Though the patch 
> still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
>     http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 04e2a3ddca51 
>   indra/newview/llviewerregion.h 04e2a3ddca51 
>   indra/newview/llviewerregion.cpp 04e2a3ddca51 
>   indra/newview/llvoicevivox.h 04e2a3ddca51 
>   indra/newview/llvoicevivox.cpp 04e2a3ddca51 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Reply via email to