----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review896 -----------------------------------------------------------
indra/newview/llparticipantlist.cpp <http://codereview.secondlife.com/r/404/#comment939> Either this comment should be moved inside the if-block or it should be formulated as a question: // Is agent in group call? Otherwise it might give the wrong impression that it is already known that the agent is in a group call at the point where the comment appears. Also, is this really about group calls (i.e. voice) or rather/also group chat (i.e. text). indra/newview/llparticipantlist.cpp <http://codereview.secondlife.com/r/404/#comment941> I think if the speaker manager is missing (pointer is null), at least a warning in the log would be warranted. I'm not sure whether the same applies for missing (i.e. null) speaker. (Could the agent have left the group call/chat meanwhile thus not be in the speaker list anymore?) indra/newview/llparticipantlist.cpp <http://codereview.secondlife.com/r/404/#comment940> This comment should read // Is agent a moderator? or similar. - Boroondas On July 20, 2011, 11:16 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/404/ > ----------------------------------------------------------- > > (Updated July 20, 2011, 11:16 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added null checking > > > This addresses bug storm-1458. > http://jira.secondlife.com/browse/storm-1458 > > > Diffs > ----- > > indra/newview/llparticipantlist.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/404/diff > > > Testing > ------- > > > Thanks, > > Paul > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
