> On July 21, 2011, 4:21 a.m., Boroondas Gupte wrote: > > indra/newview/llparticipantlist.cpp, lines 807-808 > > <http://codereview.secondlife.com/r/404/diff/2/?file=6722#file6722line807> > > > > Hmm ... looking at the comment at > > https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.h#cl-705 > > and the implementation of isInGroup at > > https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.cpp#cl-2414 > > , this test actually checks whether the agent in question is a member of > > the group which has an UUID matching the conversation's session ID. > > > > Because the session IDs of group chats will match the UUID of the > > respective groups (and all other chat session types should have session IDs > > not matching any group UUIDs), this also tells us whether the session is a > > group chat. > > > > So maybe the comment should be yet different to reflect this. (Sorry, > > should have looked up this stuff for the first review already.) Maybe: > > // Is session a group chat? (It is if the session ID is the > > UUID of a group of which the agent is a member.) > > > > I wonder whether there is a better way (as in: making less assumptions > > / not using an agent as pivot) to test for this.
I think the comment may be: "Is agent in group call/chat ?" - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review898 ----------------------------------------------------------- On July 21, 2011, 3:27 a.m., Paul ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/404/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 3:27 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added null checking > > > This addresses bug storm-1458. > http://jira.secondlife.com/browse/storm-1458 > > > Diffs > ----- > > indra/newview/llparticipantlist.cpp d8c37b383028 > > Diff: http://codereview.secondlife.com/r/404/diff > > > Testing > ------- > > > Thanks, > > Paul > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
