> On Aug. 16, 2011, 1:19 p.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/notifications.xml, lines 5901-5906 > > <http://codereview.secondlife.com/r/442/diff/1/?file=6943#file6943line5901> > > > > Shouldn't the same change be made in the translations?
Ah, right. Thanks, will fix. On Aug. 16, 2011, 1:19 p.m., Vadim ProductEngine wrote: > > > The fix may look weird because we seem to wrap a SLURL with > > > <nolink>...</nolink> tags. > > > But actually there is no SLURL, there's just an object name. > > > > If that is so (and the comment on indra/newview/llviewermessage.cpp line > > 1941 indicates it is), why not rename the placeholder to ITEM_NAME or > > similar? I think the only places where this change would have to be made > > are llviewermessage.cpp line 1942, the message above and its translations. Because there *is* a SLURL being passed via ITEM_SLURL (see llviewermessage.cpp:1934). It's just becomes a plain name on its way. So if we simply rename ITEM_SLURL to ITEM_NAME, we'll just hide the bug. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/442/#review979 ----------------------------------------------------------- On Aug. 16, 2011, 9:22 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/442/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2011, 9:22 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Disallowed parsing HTTP URLs in llGiveInventory notifications (one more case). > > The fix may look weird because we seem to wrap a SLURL with > <nolink>...</nolink> tags. > But actually there is no SLURL, there's just an object name. > Investigating that goes beyond the bug scope. > > > This addresses bug STORM-793. > http://jira.secondlife.com/browse/STORM-793 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/notifications.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/442/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
