On Thu 04 Mar, Dr Stephen Henson wrote:
> > #3 Possible lack of syslog. The syslog BIO module 'bss_log.c'
> > wants syslog but the OS may not have that functionality.
> > Not sure how openssl group want to handle stuff like this
> > so I have no suggestion here. I simply removed bss_log
> > from the Makefile in crypto/bio to continue.
> >
>
> Hmm... I've got this currently with #ifdef'ed out when "generic" WIN32
> is used: i.e. WIN32 but not WINNT defined. I could surround it in a
> NO_SYSLOG and have generic WIN32 define this.
As a general rule I believe it is a bad idea to have anything in the code
along the lines of #ifdef WINDOWS, #ifdef MAC etc. unless it is surrounding a
function that is guaranteed to pnly exist on that platform. And even in that
case it is probably better to stick it in a os dependant file or similar.
It is much easier for those of us porting to non-mainstream OS's to be able
to pick and choose from the variants needed in a header file than to go
laboriously through the source adding our OS's to the #ifdefs.
We could all submit patches to change the little bits, but it would be better
done in a more coordinated way - and perhaps with a better structured e_os.h
at the head of it.
Mote this is meant to be a helpful suggestion, not a gripe...
Simon.
--
Simon Middleton, Principal Software Engineer, Custom Engineering
Element 14 Ltd Tel: +44 (0) 1223 725576
645 Newmarket Road Fax: +44 (0) 1223 725676
Cambridge, CB5 8PB, United Kingdom WWW: http://www.e-14.com/
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
