Simon Middleton wrote:
> 
> On Thu 04 Mar, Dr Stephen Henson wrote:
> > > #3   Possible lack of syslog. The syslog BIO module 'bss_log.c'
> > >      wants syslog but the OS may not have that functionality.
> > >      Not sure how openssl group want to handle stuff like this
> > >      so I have no suggestion here. I simply removed bss_log
> > >      from the Makefile in crypto/bio to continue.
> > >
> >
> > Hmm... I've got this currently with #ifdef'ed out when "generic" WIN32
> > is used: i.e. WIN32 but not WINNT defined. I could surround it in a
> > NO_SYSLOG and have generic WIN32 define this.
> 
> As a general rule I believe it is a bad idea to have anything in the code
> along the lines of #ifdef WINDOWS, #ifdef MAC etc. unless it is surrounding a
> function that is guaranteed to pnly exist on that platform. And even in that
> case it is probably better to stick it in a os dependant file or similar.

I agree.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to