In message <[EMAIL PROTECTED]> on Mon, 1 Dec 2003 17:27:46 -0500, Geoff Thorpe <[EMAIL PROTECTED]> said:
geoff> Hi Andy (and anyone else that's interested), geoff> geoff> As part of the general hackathon/audit we're doing in geoff> crypto/bn/ I once again came across the curious zeroing code in geoff> bn_expand2, only this time I figured it was high time for me to geoff> actually ask you about it. :-) geoff> geoff> I understand the desire to cater for CPU pipelining with the geoff> 8-wise loop unrolling, but is this a better solution than just geoff> using memset() and letting the compiler take care of the same geoff> sort of thing? There are several such loops. One is the one you're talking about, but you should also look in bn_expand_internal(). I have no personal problems with switching to using memset() and memcpy() (for bn_expand_internal()), unless a function call gives an unacceptable overhead. If we switch to use the mem* variant in bn_expand_internal(), it needs to be corrected. The current form is unbelievingly buggy (I didn't even look at it last I played around with this code, since it was disabled). ----- Please consider sponsoring my work on free software. See http://www.free.lp.se/sponsoring.html for details. You don't have to be rich, a $10 donation is appreciated! -- Richard Levitte \ Tunnlandsvägen 3 \ [EMAIL PROTECTED] [EMAIL PROTECTED] \ S-168 36 BROMMA \ T: +46-8-26 52 47 \ SWEDEN \ or +46-708-26 53 44 Procurator Odiosus Ex Infernis -- [EMAIL PROTECTED] Member of the OpenSSL development team: http://www.openssl.org/ Unsolicited commercial email is subject to an archival fee of $400. See <http://www.stacken.kth.se/~levitte/mail/> for more info. ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
