Andy Polyakov wrote:
and it's now pretty hard to get a reasonable diff between the last working version (the one from cca midnight) and now.
I know, that's why I said "bear with me":-) Do try to replace return 0; in padlock_aes_cipher with return 1;...
This works, yes. Is it correct to return 1 even if (nbytes&0x0F)? Or should this never happen?
And one more thing I just noticed. In the loops of all modes you always use chunk=REALIGN_SIZE instead of chunk=min(nbytes,REALIGN_SIZE). Is this a mistake or am I again missing something?
What was incorrect on loading IV from ctx to cdata before calling xcrypt and saving it there afterwards? (And the code was much more readable ;-)
Imagine CBC encryption pass, a lot of data, all pointers unaligned. [...]
I see. Right...
Are you working on any other changes? Just to know if I can start reindenting the code to my "liking" ;-)
Michal Ludvig ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
