Richard Levitte wrote: ...
Index: openssl/crypto/pem/pem_lib.c
============================================================================
$ cvs diff -u -r1.36.2.10 -r1.36.2.11 pem_lib.c
--- openssl/crypto/pem/pem_lib.c 5 Dec 2004 01:04:38 -0000 1.36.2.10
+++ openssl/crypto/pem/pem_lib.c 27 Jan 2005 01:47:27 -0000 1.36.2.11
@@ -432,6 +432,7 @@
int o;
const EVP_CIPHER *enc=NULL;
char *p,c;
+ char **header_pp = &header;
cipher->cipher=NULL;
if ((header == NULL) || (*header == '\0') || (*header == '\n'))
@@ -478,7 +479,8 @@
PEMerr(PEM_F_PEM_GET_EVP_CIPHER_INFO,PEM_R_UNSUPPORTED_ENCRYPTION);
return(0);
}
- if (!load_iv((unsigned char **)&header,&(cipher->iv[0]),enc->iv_len)) return(0);
+ if (!load_iv((unsigned char **)header_pp,&(cipher->iv[0]),enc->iv_len))
+ return(0);
wouldn't it be cleaner to change the first parameter of the local function load_iv from "unsigned char **" to "char **" (and than change "from" in load_iv to "char" as well) ? The fact that the first parameter of load_iv is an "unsigned char **", and not just a "char **", is nowhere used and hence this workaround is superfluous (and a bit ugly ;-)
Cheers, Nils ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [EMAIL PROTECTED]
