This patch adds support to Intel AES-NI instruction set for x86_64
platform.
Cool. I'm relying on Andy to provide a more thorough review
Even after short glance I can tell there will be a lot of comments and
even work to do, but I'm planning to take it later... ... ... ... ...
Also, if you have no philosophical objection, I think the file and symbol
naming should be based on the interface rather than the manufacturer
(particularly for "intel", who provide lots of h/w and interfaces that
have nothing to do with AES-NI). Perhaps eng_aesni.c rather than
eng_intel.c.
I second it. Ying, there is nothing preventing us from renaming files
and functions (assuming that you have no philosophical objections), but
*if* you choose to submit another patch with alternative naming, could
you look into crypto/modes and use it? At earlier occasion you commented
"hope that it can be merged quickly," but it was committed to OpenSSL
CVS prior I mentioned it... Or is it that you might have failed to pull
it to your repository, but then it's something we have no power to make
quicker...
Out of curiosity, what does "NI" stand for anyway? Or is it just
something the knights kept saying? But didn't they stop doing so? Cheers. A.
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [email protected]
Automated List Manager [email protected]
