On Wed, 2008-12-24 at 00:58 +0800, Andy Polyakov wrote: > >> This patch adds support to Intel AES-NI instruction set for x86_64 > >> platform. > > > > Cool. I'm relying on Andy to provide a more thorough review > > Even after short glance I can tell there will be a lot of comments and > even work to do, but I'm planning to take it later... ... ... ... ... > > > Also, if you have no philosophical objection, I think the file and symbol > > naming should be based on the interface rather than the manufacturer > > (particularly for "intel", who provide lots of h/w and interfaces that > > have nothing to do with AES-NI). Perhaps eng_aesni.c rather than > > eng_intel.c. > > I second it. Ying, there is nothing preventing us from renaming files > and functions (assuming that you have no philosophical objections), but > *if* you choose to submit another patch with alternative naming, could > you look into crypto/modes and use it? At earlier occasion you commented > "hope that it can be merged quickly," but it was committed to OpenSSL > CVS prior I mentioned it... Or is it that you might have failed to pull > it to your repository, but then it's something we have no power to make > quicker...
It seems that crypto/modes is not compiled in libcrypto by default. The
following patch can be used to make it compiled.
It should be a separate patch or just merged it into AES-NI patch?
---
Makefile.org | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/Makefile.org
+++ b/Makefile.org
@@ -119,7 +119,7 @@ SDIRS= \
bn ec rsa dsa ecdsa dh ecdh dso engine \
buffer bio stack lhash rand err \
evp asn1 pem x509 x509v3 conf txt_db pkcs7 pkcs12 comp ocsp ui krb5 \
- cms pqueue ts jpake
+ cms pqueue ts jpake modes
# keep in mind that the above list is adjusted by ./Configure
# according to no-xxx arguments...
signature.asc
Description: This is a digitally signed message part
