Hello,

Hodie III Non. Mar. MMIX, Sune Rievers scripsit:
> Included are patches for OpenSSL 0.9.8j

[...]

> diff -u -p a/crypto/dso/dso_lib.c b/crypto/dso/dso_lib.c
> --- a/crypto/dso/dso_lib.c 2003-12-27 15:40:08.000000000 +0100
> +++ b/crypto/dso/dso_lib.c 2009-03-02 16:29:40.000000000 +0100
> @@ -400,8 +400,6 @@ char *DSO_merge(DSO *dso, const char *fi
>                 return(NULL);
>                 }
>         if(filespec1 == NULL)
> -               filespec1 = dso->filename;
> -       if(filespec1 == NULL)
>                 {
>                 DSOerr(DSO_F_DSO_MERGE,DSO_R_NO_FILE_SPECIFICATION);
>                 return(NULL);

This one is interesting. It disallows the use of dso->filename. I
suppose it wasn't intended. Looks like a bug in Coccinelle to me.

Nothing is asserted on the value of dso->filename, one can only be
sure that dso isn't NULL.

Good job for a ladybug :) (that's what "coccinelle" means, in french).

-- 
Erwann ABALEA <erwann.aba...@keynectis.com>
-----
OK to continue?  <Yes> <No> <Maybe>
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           majord...@openssl.org

Reply via email to