2009/3/6 Sune Rievers <sune.riev...@gmail.com>:
> 2009/3/6 Erwann ABALEA <erwann.aba...@keynectis.com>:
>> Hello,
>>
>> Hodie III Non. Mar. MMIX, Sune Rievers scripsit:
>>> Included are patches for OpenSSL 0.9.8j
>>
>> [...]
>>
>>> diff -u -p a/crypto/dso/dso_lib.c b/crypto/dso/dso_lib.c
>>> --- a/crypto/dso/dso_lib.c 2003-12-27 15:40:08.000000000 +0100
>>> +++ b/crypto/dso/dso_lib.c 2009-03-02 16:29:40.000000000 +0100
>>> @@ -400,8 +400,6 @@ char *DSO_merge(DSO *dso, const char *fi
>>> return(NULL);
>>> }
>>> if(filespec1 == NULL)
>>> - filespec1 = dso->filename;
>>> - if(filespec1 == NULL)
>>> {
>>> DSOerr(DSO_F_DSO_MERGE,DSO_R_NO_FILE_SPECIFICATION);
>>> return(NULL);
>>
>> This one is interesting. It disallows the use of dso->filename. I
>> suppose it wasn't intended. Looks like a bug in Coccinelle to me.
>>
>> Nothing is asserted on the value of dso->filename, one can only be
>> sure that dso isn't NULL.
>>
>
> I agree, I just became aware of this - and it sure looks like
> something was wrong in the script or in Coccinelle.
>
>> Good job for a ladybug :) (that's what "coccinelle" means, in french).
>
> Thanks, glad to help :)
>
> /Sune
>
>> --
>> Erwann ABALEA <erwann.aba...@keynectis.com>
>> -----
>> OK to continue? <Yes> <No> <Maybe>
>> ______________________________________________________________________
>> OpenSSL Project http://www.openssl.org
>> Development Mailing List openssl-dev@openssl.org
>> Automated List Manager majord...@openssl.org
>>
>
Regarding my patch for crypto/dso/dso_lib.c, I've looked through the
source code again and found that since
filespec1 can never be NULL in the two cases, the two last comparisons
should be removed, as their conditions will never be true.
So it was not exactly a bug in Coccinelle, it just missed one of the
cases where the comparison to NULL was moot.
Anyway, I've noticed it has been fixed in cvs, so just disregard that
submission.
Best regards,
Sune Rievers
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-dev@openssl.org
Automated List Manager majord...@openssl.org
