Richard Levitte wrote:
>   OpenSSL CVS Repository
>   http://cvs.openssl.org/
>   ____________________________________________________________________________
> 
>   Server: cvs.openssl.org                  Name:   Richard Levitte
>   Root:   /v/openssl/cvs                   Email:  [email protected]
>   Module: openssl                          Date:   26-Apr-2009 14:16:08
>   Branch: HEAD                             Handle: 2009042613160800
> 
>   Modified files:
>     openssl/apps            dgst.c
> 
>   Log:
>     Cast to avoid signedness confusion

Wouldn't it be better to make len signed, if it actually is?

> 
>   Summary:
>     Revision    Changes     Path
>     1.56        +1  -1      openssl/apps/dgst.c
>   ____________________________________________________________________________
> 
>   patch -p0 <<'@@ .'
>   Index: openssl/apps/dgst.c
>   ============================================================================
>   $ cvs diff -u -r1.55 -r1.56 dgst.c
>   --- openssl/apps/dgst.c     15 Apr 2009 15:26:50 -0000      1.55
>   +++ openssl/apps/dgst.c     26 Apr 2009 12:16:08 -0000      1.56
>   @@ -594,7 +594,7 @@
>       else
>               {
>               len=BIO_gets(bp,(char *)buf,BUFSIZE);
>   -           if (len <0) 
>   +           if ((int)len <0)
>                       {
>                       ERR_print_errors(bio_err);
>                       return 1;
>   @@ .
> ______________________________________________________________________
> OpenSSL Project                                 http://www.openssl.org
> CVS Repository Commit List                     [email protected]
> Automated List Manager                           [email protected]
> 
> 


-- 
http://www.apache-ssl.org/ben.html           http://www.links.org/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [email protected]

Reply via email to