Richard Levitte wrote: > In message <[email protected]> on Sun, 03 May 2009 20:13:20 +0100, > Ben Laurie <[email protected]> said: > > ben> Richard Levitte wrote: > ben> > OpenSSL CVS Repository > ben> > http://cvs.openssl.org/ > ben> > > ____________________________________________________________________________ > ben> > > ben> > Server: cvs.openssl.org Name: Richard Levitte > ben> > Root: /v/openssl/cvs Email: [email protected] > ben> > Module: openssl Date: 26-Apr-2009 14:16:08 > ben> > Branch: HEAD Handle: 2009042613160800 > ben> > > ben> > Modified files: > ben> > openssl/apps dgst.c > ben> > > ben> > Log: > ben> > Cast to avoid signedness confusion > ben> > ben> Wouldn't it be better to make len signed, if it actually is? > > I agree, but it's passed by address to some function taking a size_t*, > which means there's gonna be a cast somewhere anyway. I simply took > the easiest route.
Then one has to wonder why it is being tested for < 0. > Really, we need to harmonize our uses of size_t, int, long and so > on... It's a big job. Yeah. I started on it once. It was a mess :-) -- http://www.apache-ssl.org/ben.html http://www.links.org/ "There is no limit to what a man can do or how far he can go if he doesn't mind who gets the credit." - Robert Woodruff ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
