[openssl.org #2490] [PATCH] Crypto: Eliminate the unneccesary "tmp_bn" variable usage

[Laszlo Papp via RT]

Hi,

>From the code:
http://cvs.openssl.org/fileview?f=openssl/crypto/ec/ecp_nist.c&v=1.32

Can the 'tmp_bn' be removed as far as it is not used anywhere ?
if ((tmp_bn = BN_CTX_get(ctx)) == NULL) goto err;
(also declaration removal)

Please englighten me if I am mistaken about it and thank you in advance ! :-)

Best Regards,
Laszlo Papp


--- ../tmp/openssl-SNAP-20110407/crypto/ec/ecp_nist.c   2011-02-14 
19:00:02.000000000 +0200
+++ crypto/ec/ecp_nist.c        2011-04-08 10:46:22.243333451 +0300
@@ -125,13 +125,12 @@
        {
        int ret = 0;
        BN_CTX *new_ctx = NULL;
-       BIGNUM *tmp_bn;
        
        if (ctx == NULL)
                if ((ctx = new_ctx = BN_CTX_new()) == NULL) return 0;
 
        BN_CTX_start(ctx);
-       if ((tmp_bn = BN_CTX_get(ctx)) == NULL) goto err;
+       if (BN_CTX_get(ctx) == NULL) goto err;
 
        if (BN_ucmp(BN_get0_nist_prime_192(), p) == 0)
                group->field_mod_func = BN_nist_mod_192;