[openssl.org #2491] [PATCH] Crypto: Eliminate the unneccesary "vv" variable usage

[Laszlo Papp via RT]

Hi,

>From the code:
http://cvs.openssl.org/fileview?f=openssl/crypto/conf/conf_api.c&v=1.18.2.1

I think 'vv' could also be eliminated from the last function
(_CONF_new_section) there and the assert could be called directly on
the method.

Please englighten me if I am mistaken about it and thank you in advance ! :-)

Best Regards,
Laszlo Papp


--- crypto/conf/conf_api.c      2011-04-08 10:54:28.063333450 +0300
+++ ../tmp/openssl-SNAP-20110407/crypto/conf/conf_api.c 2010-06-12 
18:00:19.000000000 +0300
@@ -270,7 +270,7 @@
        {
        STACK_OF(CONF_VALUE) *sk=NULL;
        int ok=0,i;
-       CONF_VALUE *v=NULL;
+       CONF_VALUE *v=NULL,*vv;
 
        if ((sk=sk_CONF_VALUE_new_null()) == NULL)
                goto err;
@@ -284,7 +284,8 @@
        v->name=NULL;
        v->value=(char *)sk;
        
-       OPENSSL_assert(lh_CONF_VALUE_insert(conf->data,v) == NULL);
+       vv=lh_CONF_VALUE_insert(conf->data,v);
+       OPENSSL_assert(vv == NULL);
        ok=1;
 err:
        if (!ok)