On 12/26/13 08:03 PM, David Miller wrote:
From: Valerie Anne Bubb Fenwick <valerie.fenw...@oracle.com> Date: Thu, 26 Dec 2013 15:46:42 -0800both Dan and Misaki have noted, though, that this specific SPARC instruction OpenSSL is checking for never existed and will never exist in any SPARC chipset that Sun/Oracle shipped. Could we at least remove that check? That capability does not and will not exist, so it seems a waste of cycles to check (and confuses users, we get lots of questions about this specific instruction and why it doesn't work or which platform it should work on) Does that make sense? thanks!I'm against this on fundamental grounds, you are just pushing the problem around rather than truly fixing the issue. I know what you want, you want the SIGILL to not happen on the systems you most care about, and this is how you're going to go about doing it rather than solving this issue at it's core. In the debugger. That's really distasteful to me. Please fix things properly, rather than chase after a scarecrow like this random instruction.
Hi David,I really don't understand the desire to preserve dead, never-used code in OpenSSL. The SPARC random instruction doesn't exist, OpenSSL never used it and never can use it, but you don't want to remove the check for it. It seems silly to me.
Dan -- uosบǝpuɐ uɐp dan.ander...@oracle.com, Oracle Solaris, San Diego, +1 858-526-9418
smime.p7s
Description: S/MIME Cryptographic Signature