In this case, the exception is just hard to debug, and not something we expected in our design. The thorough solution would be to debug further to see the root cause, and deal with it as I suggested in the code review.
However, If it is time consuming to debug, we can put the patch in there with logging to record the circumstances the 'unexpected' exception occurs, so that we can put in new patches to deal it when it becomes expected. After all, this is an iterative process. When the software evolves, a lot of unexpected has become expected. -----Original Message----- From: Raymond Pekowski (Code Review) [mailto:rev...@openstack.org] Sent: Tuesday, June 25, 2013 9:52 AM Cc: Dirk Mueller; Andrea Rosa; Ben Nemec; Chris Behrens; Eric Windisch; Russell Bryant; Qing He Subject: Change in openstack/oslo-incubator[master]: Make AMQP based RPC consumer threads more robust Raymond Pekowski has posted comments on this change. Change subject: Make AMQP based RPC consumer threads more robust ...................................................................... Patch Set 12: By definition, unexpected exceptions are unexpected, so there is nothing yet to do root cause analysis on. We could argue as to what the appropriate action to take is, but that has already been discussed on the mailing list started by this thread: http://lists.openstack.org/pipermail/openstack-dev/2013-June/010040.html Please comment on that thread since you don't agree with the consensus that was reached. -- To view, visit https://review.openstack.org/32235 To unsubscribe, visit https://review.openstack.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d6ec8a5e3a310314da201656ee862bb40b41616 Gerrit-PatchSet: 12 Gerrit-Project: openstack/oslo-incubator Gerrit-Branch: master Gerrit-Owner: Raymond Pekowski <raymond_pekow...@dell.com> Gerrit-Reviewer: Andrea Rosa <andrea.r...@hp.com> Gerrit-Reviewer: Ben Nemec <openst...@nemebean.com> Gerrit-Reviewer: Chris Behrens <cbehr...@codestud.com> Gerrit-Reviewer: Dirk Mueller <d...@dmllr.de> Gerrit-Reviewer: Eric Windisch <e...@cloudscaling.com> Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Qing He <qing...@radisys.com> Gerrit-Reviewer: Raymond Pekowski <raymond_pekow...@dell.com> Gerrit-Reviewer: Russell Bryant <rbry...@redhat.com> _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
