Basically, when 'unexpected' happens, someone (e.g., operator) needs to know about it and look into it to see if it is something benign or fatal. If it is masked, the system may degrade overtime unnoticed into unusable.
-----Original Message----- From: Qing He Sent: Tuesday, June 25, 2013 10:16 AM To: '[email protected]'; [email protected] Cc: Dirk Mueller; Andrea Rosa; Ben Nemec; Chris Behrens; Eric Windisch; Russell Bryant Subject: re: [openstack-dev] Should RPC consume_in_thread() be more fault tolerant? In this case, the exception is just hard to debug, and not something we expected in our design. The thorough solution would be to debug further to see the root cause, and deal with it as I suggested in the code review. However, If it is time consuming to debug, we can put the patch in there with logging to record the circumstances the 'unexpected' exception occurs, so that we can put in new patches to deal it when it becomes expected. After all, this is an iterative process. When the software evolves, a lot of unexpected has become expected. -----Original Message----- From: Raymond Pekowski (Code Review) [mailto:[email protected]] Sent: Tuesday, June 25, 2013 9:52 AM Cc: Dirk Mueller; Andrea Rosa; Ben Nemec; Chris Behrens; Eric Windisch; Russell Bryant; Qing He Subject: Change in openstack/oslo-incubator[master]: Make AMQP based RPC consumer threads more robust Raymond Pekowski has posted comments on this change. Change subject: Make AMQP based RPC consumer threads more robust ...................................................................... Patch Set 12: By definition, unexpected exceptions are unexpected, so there is nothing yet to do root cause analysis on. We could argue as to what the appropriate action to take is, but that has already been discussed on the mailing list started by this thread: http://lists.openstack.org/pipermail/openstack-dev/2013-June/010040.html Please comment on that thread since you don't agree with the consensus that was reached. -- To view, visit https://review.openstack.org/32235 To unsubscribe, visit https://review.openstack.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d6ec8a5e3a310314da201656ee862bb40b41616 Gerrit-PatchSet: 12 Gerrit-Project: openstack/oslo-incubator Gerrit-Branch: master Gerrit-Owner: Raymond Pekowski <[email protected]> Gerrit-Reviewer: Andrea Rosa <[email protected]> Gerrit-Reviewer: Ben Nemec <[email protected]> Gerrit-Reviewer: Chris Behrens <[email protected]> Gerrit-Reviewer: Dirk Mueller <[email protected]> Gerrit-Reviewer: Eric Windisch <[email protected]> Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Qing He <[email protected]> Gerrit-Reviewer: Raymond Pekowski <[email protected]> Gerrit-Reviewer: Russell Bryant <[email protected]> _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
