On Thu, Aug 15, 2013 at 7:12 AM, Christopher Yeoh <cbky...@gmail.com> wrote:
> > On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins < > robe...@robertcollins.net> wrote: > >> This may interest data-driven types here. >> >> >> https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ >> >> Note specifically the citation of 200-400 lines as the knee of the review >> effectiveness curve: that's lower than I thought - I thought 200 was >> clearly fine - but no. >> >> > Very interesting article. One other point which I think is pretty relevant > is point 4 about getting authors to annotate the code better (and for those > who haven't read it, they don't mean comments in the code but separately) > because it results in the authors picking up more bugs before they even > submit the code. > +one million > > So I wonder if its worth asking people to write more detailed commit logs > which include some reasoning about why some of the more complex changes > were done in a certain way and not just what is implemented or fixed. As it > is many of the commit messages are often very succinct so I think it would > help on the review efficiency side too. > > Chris > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Anne Gentle annegen...@justwriteclick.com
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
