Awesome, I appreciate the work here. I spoke with a couple Django folk on IRC and they didn’t have any other solution than “vendor the code”, so I think your approach is probably the most reasonable. I’m fairly annoyed that they dropped an interface like that, but oh well.
I’ll take a look at the patch and give some feedback. Hoping to also get some feedback on the D_O_A merge this week too, otherwise I’ll probably just go ahead and do it. Rob On 17 Jul 2017, at 09:12, Adrian Turjak <[email protected]<mailto:[email protected]>> wrote: Was hoping to play with this much sooner, but here is a quick hack for horizon working with django 1.11 https://review.openstack.org/#/c/484277/ The main issues are with widgets from Django which are no longer there, and all I've done is move them to our repo from django 1.10's code. This is probably not a good long term solution. Then django-babel doesn't yet have a version that has django 1.11 support, although the change has been merged to master. Just needs a new release. For now a install from source works to test. And... because it was easier, I did this off the patch that brings openstack_auth into horizon. Because of some import order changes in django (I assume), there was an issue due to an import that caused a call to get_user_model before openstack_auth was fully loaded. Beyond that, it all 'appears' to work. I launched some instances, created some networks, changed my password, managed some projects and users. There is tons to actually test, but mostly it just seems to work. On 05/07/17 22:24, Rob Cresswell (rcresswe) wrote: If you want to install Django 1.11 and test it, that would be very helpful, even if its just to open bugs. I’m in the process of adding a non-voting job for 1.11 right now, so we should be able to move quickly. Rob On 5 Jul 2017, at 01:36, Adrian Turjak <[email protected]<mailto:[email protected]>> wrote: Great work! Is there anything that can be done to help meet that July deadline and get 1.11.x in? I'm more than happy to help with reviews or even fixes for newer Django in Horizon, and we should try and get others involved if it will help as I think this is a little urgent. Running anything less than Django 1.11 leaves us in a weird spot because of the point where support ends for any versions below it. Looking at the release timelines, if we don't get 1.11 in for Pike, we'll have released a version of Horizon that will be for an unsupported version of Django in about 6 months time (8 if deployers stick with django 1.8): https://releases.openstack.org/pike/schedule.html https://www.djangoproject.com/download/ It isn't as bad it could be, but it's an awkward situation to be in. 1.9 is no longer supported, 1.10 support stops at 2018, so realistically 1.8 is the only version to have Pike 'safe' until Queens thats not particularly great either. Getting 1.11 support in would be ideal. On 05/07/17 03:01, Rob Cresswell wrote: Hi everyone, I've put up a patch to global-requirements to raise the Django cap to "<1.11", with the upper-constraint at "1.10.7" (https://review.openstack.org/#/c/480215). Depending on the remaining time, I'd quite like to move us to "1.11.x" before Requirements Freeze, which will fall around the 27th of July. Rob __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe<mailto:[email protected]?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]<mailto:[email protected]>?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe<mailto:[email protected]?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]<mailto:[email protected]>?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
